Skip to content

Commit

Permalink
fix(auth): removed the shareReplay from auth and addressed Zone.js is…
Browse files Browse the repository at this point in the history
…sues (#2682)

* Only `keepUnstableUntilFirst` on `redirectResult`, `shareReplay` it
* Remove shareReplay which causes issues when loading/checking auth lazily
* Move guards over to `.user` so token changes will be evaluated
* Upgrade the node modules in sample

Closes #2681
  • Loading branch information
jamesdaniels authored Nov 24, 2020
1 parent 6817bcc commit 059547b
Show file tree
Hide file tree
Showing 5 changed files with 890 additions and 1,211 deletions.
1 change: 1 addition & 0 deletions sample/src/app/auth/auth.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ export class AuthComponent implements OnInit, OnDestroy {
showLogoutButton = false;

constructor(public readonly auth: AngularFireAuth, @Inject(PLATFORM_ID) platformId: object) {

if (!isPlatformServer(platformId)) {
this.userDisposable = this.auth.authState.pipe(
trace('auth'),
Expand Down
Loading

0 comments on commit 059547b

Please sign in to comment.