Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): avoid referring to arguments in arrow functions #3127

Merged
merged 2 commits into from
Feb 7, 2022
Merged

fix(core): avoid referring to arguments in arrow functions #3127

merged 2 commits into from
Feb 7, 2022

Conversation

lacolaco
Copy link
Contributor

Checklist

Description

  • Define a _arguments variable and copy values of arguments into that.
  • Avoid to direct referring to arguments in arrow functions

Code sample

@lacolaco lacolaco mentioned this pull request Jan 21, 2022
Closed
@jamesdaniels
Copy link
Member

Thanks for tracking this down!

@jamesdaniels jamesdaniels enabled auto-merge (squash) February 7, 2022 05:14
@jamesdaniels jamesdaniels merged commit 8b693e4 into angular:master Feb 7, 2022
@lacolaco lacolaco deleted the fix-3126 branch February 14, 2022 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesdaniels jamesdaniels jamesdaniels approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lacolaco @jamesdaniels