Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code in schematics/deploy/builder.ts is preventing the usage of any non-default firebaseProject and firebaseHostingSite values #3077

Open
itsdarja opened this issue Nov 28, 2021 · 11 comments · May be fixed by #3284
Open

Code in schematics/deploy/builder.ts is preventing the usage of any non-default firebaseProject and firebaseHostingSite values #3077

itsdarja opened this issue Nov 28, 2021 · 11 comments · May be fixed by #3284
Assignees
@davideast

Comments

@itsdarja
Copy link

itsdarja commented Nov 28, 2021 •
edited
Loading

Version info

Angular:
13.0.3

Firebase:
0.22.0

AngularFire:
7.2.0

Other (e.g. Ionic/Cordova, Node, browser, operating system):
Node:
v16.13.0

How to reproduce these conditions

Trying to accomplish working with multiple firebase projects for deployment as per instructions here: https://stackblitz.com/edit/angular-fire-start

Steps to set up and reproduce

When I try to set the different configurations for deploy command - for example:

 "deploy": {
     "builder": "@angular/fire:deploy",
      "options": {
          "prerender": false,
          "ssr": false,
          "browserTarget": "mypage:build:staging",
          "firebaseProject": "mypage-stg",
          "firebaseHostingSite": "mypage-stg"
      },
      "configurations": {
          "production": {
             "browserTarget": "mypage:build:production",
             "firebaseProject": "mypage-prod",
             "firebaseHostingSite": "mypage-prod"
          }
      }
}

And then run:
ng deploy --configuration="production"

This results with error:
An unhandled exception occurred: The Firebase Project specified by your angular.json or .firebaserc is in conflict

Debug output

An unhandled exception occurred: The Firebase Project specified by your angular.json or .firebaserc is in conflict

Looking at the text I identified the issues being the lines 25 and 33 in this file:
https://github.com/angular/angularfire/blob/master/src/schematics/deploy/builder.ts

Problematic code parts:

 if (!firebaseProject) {
    throw new Error('Cannot detirmine the Firebase Project from your angular.json or .firebaserc');
}
if (firebaseProject !== defaultFirebaseProject) {
    throw new Error('The Firebase Project specified by your angular.json or .firebaserc is in conflict');
}

and

const firebaseHostingSite = options.firebaseHostingSite || defulatFirebaseHostingSite;
if (!firebaseHostingSite) {
    throw new Error(`Cannot detirmine the Firebase Hosting Site from your angular.json or .firebaserc`);
}
if (firebaseHostingSite !== defulatFirebaseHostingSite) {
    throw new Error('The Firebase Hosting Site specified by your angular.json or .firebaserc is in conflict');
}

I can not make the sense out of this code.
Why would you prevent deploying any other value of the configuration other the default value?

Commenting out lines 25 and 33 results in the successful deployment of the desired configuration.

Expected behaviour

Being able to configure different firebase projects and hosting sites for the same project

Actual behaviour

Throwing errors when trying to use firebaseProject and firebaseHostingSite different from defaultFirebaseProject and defulatFirebaseHostingSite.

Edit: Duplicate of #3076 -> for some reason I thought that one was already closed
@google-oss-bot
Copy link

This issue does not seem to follow the issue template. Make sure you provide all the required information.

@YegorPavlenko
Copy link

Error in the https://github.com/angular/angularfire/blob/master/src/schematics/utils.ts l: 100 in the function projectFromRc(...)
wrong getting project value.

@sidsaxena0
Copy link

Is there any workaround to this, I am scratching my head for last two days over this issue.

@davidecampello
Copy link

Hi, I'm having the same issue

@luca-ognissante
Copy link

Any solution to this problem?

@nontangent nontangent linked a pull request Nov 4, 2022 that will close this issue
Open
4 tasks
@kkachniarz220
Copy link

bump, any solutions?

@h11a h11a mentioned this issue Jan 20, 2023
Open
@HmFlashy
Copy link

Any solution to this?

@aponski
Copy link

aponski commented May 18, 2023

I'm also looking for the solution.

@HmFlashy
Copy link

The only workaround found is to change by hand the .firebaserc and the firebase.json with the correct target

@DieselBleifrei
Copy link

DieselBleifrei commented May 18, 2023 •
edited
Loading

you will need to seperate the steps that are done automatically by ng deploy yourself. Meaning building of server/browser and deploying the firebase function.
In my case this was:

  1. building of the project
  2. copying the index.js file which is the base file for the function in the distfolder (you will have to create the file yourself though the content is nearly the same as the index.js file that would be created by ng deploy)
  3. running npm install inside the distfolder
  4. deploying the firebase function

@davideast davideast self-assigned this Jun 23, 2023
@pdela
Copy link

pdela commented Mar 7, 2024

Any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davideast davideast

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(schematics): rewrite projectFromRc and add spec file nontangent/angularfire