Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(auth): Adding user and idTokenResult Observables #1642

Merged
merged 4 commits into from
May 14, 2018
Merged

feat(auth): Adding user and idTokenResult Observables #1642

merged 4 commits into from
May 14, 2018

Conversation

jamesdaniels
Copy link
Member

Checklist

Description

Adding user and idTokenResult to AngularFireAuth.

@jamesdaniels jamesdaniels mentioned this pull request May 14, 2018
Closed
markstuart
markstuart approved these changes May 14, 2018
View reviewed changes
Copy link

@markstuart markstuart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I like that the user subscription will fire for all auth events and that you are recommending its use instead of authState.

👍

davideast
davideast approved these changes May 14, 2018
View reviewed changes
Copy link
Member

@davideast davideast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jamesdaniels jamesdaniels mentioned this pull request May 14, 2018
Closed
@jamesdaniels jamesdaniels merged commit 31045a9 into master May 14, 2018
@jamesdaniels jamesdaniels deleted the auth_additions branch May 14, 2018 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davideast davideast davideast approved these changes

@markstuart markstuart markstuart approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jamesdaniels @markstuart @davideast @googlebot