Skip to content

Commit 0fb2e9a

Browse files
authored
feat(cdk/listbox): add listbox to cdk (#25380) (#25474)
1 parent b20876d commit 0fb2e9a

File tree

57 files changed

+166
-17
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

57 files changed

+166
-17
lines changed

.github/CODEOWNERS

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,7 @@
7777
/src/cdk/drag-drop/** @crisbeto
7878
/src/cdk/keycodes/** @andrewseguin
7979
/src/cdk/layout/** @andrewseguin
80+
/src/cdk/listbox/** @jelbourn
8081
/src/cdk/menu/** @mmalerba @crisbeto
8182
/src/cdk/observers/** @andrewseguin @crisbeto
8283
/src/cdk/overlay/** @jelbourn @crisbeto
@@ -131,7 +132,6 @@
131132
/src/cdk-experimental/popover-edit/** @andrewseguin
132133
/src/cdk-experimental/scrolling/** @mmalerba
133134
/src/cdk-experimental/table-scroll-container/** @andrewseguin
134-
/src/cdk-experimental/listbox/** @jelbourn
135135
/src/cdk-experimental/selection/** @andrewseguin
136136

137137
# Docs examples & guides
@@ -149,8 +149,8 @@
149149
/src/dev-app/button/** @andrewseguin
150150
/src/dev-app/card/** @andrewseguin
151151
/src/dev-app/cdk-dialog/** @crisbeto
152-
/src/dev-app/cdk-experimental-combobox/** @jelbourn
153-
/src/dev-app/cdk-experimental-listbox/** @jelbourn
152+
/src/dev-app/cdk-listbox/** @jelbourn
153+
/src/dev-app/cdk-experimental-combobox/** @jelbourn
154154
/src/dev-app/checkbox/** @jelbourn @devversion
155155
/src/dev-app/chips/** @andrewseguin
156156
/src/dev-app/clipboard/** @andrewseguin

.ng-dev/commit-message.mts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ export const commitMessage: CommitMessageConfig = {
1111
'multiple', // For when a commit applies to multiple components.
1212
'cdk-experimental/column-resize',
1313
'cdk-experimental/combobox',
14-
'cdk-experimental/listbox',
1514
'cdk-experimental/popover-edit',
1615
'cdk-experimental/scrolling',
1716
'cdk-experimental/selection',
@@ -26,6 +25,7 @@ export const commitMessage: CommitMessageConfig = {
2625
'cdk/drag-drop',
2726
'cdk/keycodes',
2827
'cdk/layout',
28+
'cdk/listbox',
2929
'cdk/menu',
3030
'cdk/observers',
3131
'cdk/overlay',

scripts/approve-api-golden.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,4 +32,5 @@ const apiGoldenTargetName = `//tools/public_api_guard:${packageName}/${suffix}.m
3232
// ShellJS should exit if any command fails.
3333
shelljs.set('-e');
3434
shelljs.cd(projectDir);
35+
shelljs.touch(path.join(projectDir, `tools/public_api_guard/${packageName}/${suffix}.md`));
3536
shelljs.exec(`yarn bazel run ${apiGoldenTargetName}`);

src/cdk-experimental/config.bzl

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
CDK_EXPERIMENTAL_ENTRYPOINTS = [
33
"column-resize",
44
"combobox",
5-
"listbox",
65
"popover-edit",
76
"scrolling",
87
"selection",

src/cdk/config.bzl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ CDK_ENTRYPOINTS = [
1010
"drag-drop",
1111
"keycodes",
1212
"layout",
13+
"listbox",
1314
"menu",
1415
"observers",
1516
"overlay",

src/cdk-experimental/listbox/BUILD.bazel renamed to src/cdk/listbox/BUILD.bazel

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
load("//tools:defaults.bzl", "ng_module", "ng_test_library", "ng_web_test_suite")
1+
load("//tools:defaults.bzl", "markdown_to_html", "ng_module", "ng_test_library", "ng_web_test_suite")
22

33
package(default_visibility = ["//visibility:public"])
44

@@ -37,3 +37,13 @@ ng_web_test_suite(
3737
name = "unit_tests",
3838
deps = [":unit_test_sources"],
3939
)
40+
41+
markdown_to_html(
42+
name = "overview",
43+
srcs = [":listbox.md"],
44+
)
45+
46+
filegroup(
47+
name = "source-files",
48+
srcs = glob(["**/*.ts"]),
49+
)
File renamed without changes.

src/cdk-experimental/listbox/listbox.spec.ts renamed to src/cdk/listbox/listbox.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import {fakeAsync, TestBed, tick} from '@angular/core/testing';
22
import {Component, Type} from '@angular/core';
33
import {By} from '@angular/platform-browser';
44
import {CdkListbox, CdkListboxModule, CdkOption, ListboxValueChangeEvent} from './index';
5-
import {dispatchKeyboardEvent, dispatchMouseEvent} from '../../cdk/testing/private';
5+
import {dispatchKeyboardEvent, dispatchMouseEvent} from '../testing/private';
66
import {
77
A,
88
B,

0 commit comments

Comments
 (0)