fix(material/sidenav): not closing on escape key press (#29292)

crisbeto · web-flow · commit 36c627beaff2 · 2024-06-20T21:35:30.000+02:00
Fixes that the sidenav wasn't triggering change detection when closing via a escape key press.
diff --git a/src/material/sidenav/drawer.ts b/src/material/sidenav/drawer.ts
@@ -322,6 +322,7 @@ export class MatDrawer implements AfterViewInit, AfterContentChecked, OnDestroy
   readonly _modeChanged = new Subject<void>();
 
   private _injector = inject(Injector);
+  private _changeDetectorRef = inject(ChangeDetectorRef);
 
   constructor(
     private _elementRef: ElementRef<HTMLElement>,
@@ -593,6 +594,8 @@ export class MatDrawer implements AfterViewInit, AfterContentChecked, OnDestroy
       }
     }
 
+    // Needed to ensure that the closing sequence fires off correctly.
+    this._changeDetectorRef.markForCheck();
     this._updateFocusTrapState();
 
     return new Promise<MatDrawerToggleResult>(resolve => {

Original file line number	Diff line number	Diff line change
`@@ -322,6 +322,7 @@ export class MatDrawer implements AfterViewInit, AfterContentChecked, OnDestroy`
`322`	`322`	`readonly _modeChanged = new Subject<void>();`
`323`	`323`
`324`	`324`	`private _injector = inject(Injector);`
	`325`	`+ private _changeDetectorRef = inject(ChangeDetectorRef);`
`325`	`326`
`326`	`327`	`constructor(`
`327`	`328`	`private _elementRef: ElementRef<HTMLElement>,`
`@@ -593,6 +594,8 @@ export class MatDrawer implements AfterViewInit, AfterContentChecked, OnDestroy`
`593`	`594`	`}`
`594`	`595`	`}`
`595`	`596`
	`597`	`+ // Needed to ensure that the closing sequence fires off correctly.`
	`598`	`+ this._changeDetectorRef.markForCheck();`
`596`	`599`	`this._updateFocusTrapState();`
`597`	`600`
`598`	`601`	`return new Promise<MatDrawerToggleResult>(resolve => {`