build: update to nodejs v16 and update rules_nodejs to v4 stable (#23485)

Author: devversion

.circleci/config.yml

@@ -7,18 +7,18 @@
 # To validate changes, use an online parser, eg.
 # http://yaml-online-parser.appspot.com/
 
-var_1: &docker_image circleci/node:14.16.1
-var_2: &docker-firefox-image circleci/node:14.16.1-browsers
+var_1: &docker_image circleci/node:16.6.0
+var_2: &docker-firefox-image circleci/node:16.6.0-browsers
 
 # **Note**: When updating the beginning of the cache key, also update the cache key to match
 # the new cache key prefix. This allows us to take advantage of CircleCI's fallback caching.
 # Read more here: https://circleci.com/docs/2.0/caching/#restoring-cache.
-var_3: &cache_key v8-ng-mat-{{ checksum ".bazelversion" }}-{{ checksum "tools/postinstall/apply-patches.js" }}-{{ checksum "WORKSPACE" }}-{{ checksum "yarn.lock" }}
+var_3: &cache_key v9-ng-mat-{{ checksum ".bazelversion" }}-{{ checksum "tools/postinstall/apply-patches.js" }}-{{ checksum "WORKSPACE" }}-{{ checksum "yarn.lock" }}
 # We want to invalidate the cache if the postinstall patches change. In order to apply new
 # patches, a clean version of the node modules is needed. Additionally, we invalidate the cache
 # if the Bazel version changes. We do this because otherwise the `bazelisk` cache folder will
 # contain all previously used versions and ultimately cause the cache restoring to be slower.
-var_4: &cache_fallback_key v8-ng-mat-{{ checksum ".bazelversion" }}-{{ checksum "tools/postinstall/apply-patches.js" }}-
+var_4: &cache_fallback_key v9-ng-mat-{{ checksum ".bazelversion" }}-{{ checksum "tools/postinstall/apply-patches.js" }}-
 
 # Settings common to each job
 var_5: &job_defaults

.nvmrc

@@ -1 +1 @@
-14.16.1
+16.6.0

WORKSPACE

@@ -8,8 +8,8 @@ load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
 # Add NodeJS rules
 http_archive(
     name = "build_bazel_rules_nodejs",
-    sha256 = "5c40083120eadec50a3497084f99bc75a85400ea727e82e0b2f422720573130f",
-    urls = ["https://github.com/bazelbuild/rules_nodejs/releases/download/4.0.0-beta.0/rules_nodejs-4.0.0-beta.0.tar.gz"],
+    sha256 = "8a7c981217239085f78acc9898a1f7ba99af887c1996ceb3b4504655383a2c3c",
+    urls = ["https://github.com/bazelbuild/rules_nodejs/releases/download/4.0.0/rules_nodejs-4.0.0.tar.gz"],
 )
 
 # Add sass rules
@@ -44,7 +44,7 @@ load("@build_bazel_rules_nodejs//:index.bzl", "check_bazel_version", "node_repos
 check_bazel_version("4.0.0")
 
 node_repositories(
-    node_version = "14.16.1",
+    node_version = "16.6.0",
     package_json = ["//:package.json"],
 )
 
@@ -96,6 +96,6 @@ load(
 
 _dev_infra_browser_repositories()
 
-load("@npm//@bazel/esbuild:esbuild_repositories.bzl", "esbuild_repositories")
+load("@build_bazel_rules_nodejs//toolchains/esbuild:esbuild_repositories.bzl", "esbuild_repositories")
 
 esbuild_repositories()

package.json

@@ -9,7 +9,7 @@
   },
   "license": "MIT",
   "engines": {
-    "node": ">=14.0.0 <16.0.0",
+    "node": ">=14.0.0 <17.0.0",
     "yarn": ">= 1.0.0",
     "npm": "Please use Yarn instead of NPM to install dependencies. See: https://yarnpkg.com/lang/en/docs/install/"
   },
@@ -85,15 +85,15 @@
     "@babel/traverse": "^7.13.0",
     "@bazel/bazelisk": "1.9.0",
     "@bazel/buildifier": "4.0.1",
-    "@bazel/concatjs": "4.0.0-beta.0",
-    "@bazel/esbuild": "4.0.0-beta.0",
+    "@bazel/concatjs": "4.0.0",
+    "@bazel/esbuild": "4.0.0",
     "@bazel/ibazel": "0.15.10",
-    "@bazel/jasmine": "4.0.0-beta.0",
-    "@bazel/protractor": "4.0.0-beta.0",
-    "@bazel/rollup": "4.0.0-beta.0",
-    "@bazel/runfiles": "4.0.0-beta.0",
-    "@bazel/terser": "4.0.0-beta.0",
-    "@bazel/typescript": "4.0.0-beta.0",
+    "@bazel/jasmine": "4.0.0",
+    "@bazel/protractor": "4.0.0",
+    "@bazel/rollup": "4.0.0",
+    "@bazel/runfiles": "4.0.0",
+    "@bazel/terser": "4.0.0",
+    "@bazel/typescript": "4.0.0",
     "@firebase/app-types": "^0.6.1",
     "@material/animation": "13.0.0-canary.0a9069300.0",
     "@material/auto-init": "13.0.0-canary.0a9069300.0",

src/cdk/testing/private/e2e/asserts.ts

@@ -40,7 +40,7 @@ export async function expectLocation(element: FinderResult, {x, y}: Point) {
  * Asserts that one element is aligned with another.
  */
 export async function expectAlignedWith(element: FinderResult, otherElement: FinderResult) {
-  await getElement(otherElement).getLocation().then((location: Point) => {
-    expectLocation(getElement(element), location);
+  await getElement(otherElement).getLocation().then(async (location: Point) => {
+    await expectLocation(getElement(element), location);
   });
 }

src/material-date-fns-adapter/BUILD.bazel

@@ -1,5 +1,5 @@
 load("//tools:defaults.bzl", "ng_module", "ng_package", "ng_test_library", "ng_web_test_suite")
-load(":esbuild-amd.bzl", "esbuild_amd")
+load("//tools/esbuild:index.bzl", "esbuild_amd")
 
 package(default_visibility = ["//visibility:public"])
 

src/material-date-fns-adapter/esbuild-amd.bzl

@@ -0,0 +1 @@
+exports_files(["esbuild-amd-config.mjs"])

tools/esbuild/BUILD.bazel

@@ -0,0 +1,5 @@
+export default {
+  globalName: "__exports",
+  banner: {js: 'define("TMPL_MODULE_NAME", [], function() {'},
+  footer: {js: 'return __exports;})'},
+};

tools/esbuild/esbuild-amd-config.mjs

@@ -0,0 +1,42 @@
+load("@npm//@bazel/esbuild:index.bzl", "esbuild_config", _esbuild = "esbuild")
+load("@npm//@angular/dev-infra-private/bazel:expand_template.bzl", "expand_template")
+
+def esbuild(**kwargs):
+    _esbuild(**kwargs)
+
+"""Generates an AMD bundle for the specified entry-point with the given AMD module name."""
+
+def esbuild_amd(name, entry_point, module_name, testonly, deps):
+    expand_template(
+        name = "%s_config" % name,
+        testonly = testonly,
+        template = "//tools/esbuild:esbuild-amd-config.mjs",
+        output_name = "%s_config.mjs" % name,
+        substitutions = {
+            "TMPL_MODULE_NAME": module_name,
+        },
+    )
+
+    esbuild_config(
+        name = "%s_config_lib" % name,
+        testonly = testonly,
+        config_file = "%s_config" % name,
+    )
+
+    _esbuild(
+        name = "%s_bundle" % name,
+        testonly = testonly,
+        deps = deps,
+        minify = True,
+        sourcemap = "inline",
+        platform = "browser",
+        target = "es2015",
+        entry_point = entry_point,
+        config = "%s_config_lib" % name,
+    )
+
+    native.filegroup(
+        name = name,
+        testonly = testonly,
+        srcs = ["%s_bundle" % name],
+    )