Skip to content

Commit ca634cb

Browse files
skrthebosscrisbeto
authored andcommitted
fix(cdk/drag-drop): remove preview after animate to placeholder animation completes (#29439)
* fix(cdk/drag-drop): remove preview after animate to placeholder animation completes The comparison between the event target element and this._preview never returned true because this._preview is a class, and we need to compare its element instead. This regression was introduced in commit ebab924#diff-65b82ba5c290701d792881e9e389e8f1961848abb740bb20940d4383dfae4eacL121-R117. * fixup! fix(cdk/drag-drop): remove preview after animate to placeholder animation completes Fix linting error (cherry picked from commit 5655661)
1 parent d57e6a5 commit ca634cb

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

Diff for: src/cdk/drag-drop/drag-ref.ts

+3-1
Original file line numberDiff line numberDiff line change
@@ -1100,7 +1100,9 @@ export class DragRef<T = any> {
11001100
const handler = ((event: TransitionEvent) => {
11011101
if (
11021102
!event ||
1103-
(_getEventTarget(event) === this._preview && event.propertyName === 'transform')
1103+
(this._preview &&
1104+
_getEventTarget(event) === this._preview.element &&
1105+
event.propertyName === 'transform')
11041106
) {
11051107
this._preview?.removeEventListener('transitionend', handler);
11061108
resolve();

Diff for: src/cdk/drag-drop/preview-ref.ts

+4
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,10 @@ export class PreviewRef {
3939
/** Reference to the preview element. */
4040
private _preview: HTMLElement;
4141

42+
get element(): HTMLElement {
43+
return this._preview;
44+
}
45+
4246
constructor(
4347
private _document: Document,
4448
private _rootElement: HTMLElement,

0 commit comments

Comments
 (0)