Commit d7a9cbb
fix(material/dialog): Use align as @input() in MatDialogActions
Squashed commit of the following:
commit 1d6daeadf8e06e38c64fec724d5a8d2899b502d3
Merge: 3276432 3a98da8
Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
Date: Mon Jan 31 19:24:24 2022 +0100
Merge branch 'master' into align-attr-as-input-in-dialog-actions-#18479-2
commit 3276432
Merge: 815cf8f 1f40b7d
Author: Jean-Philippe <jeanphilippe.green@gmail.com>
Date: Mon Jan 31 18:54:42 2022 +0100
Merge branch 'angular:master' into align-attr-as-input-in-dialog-actions-#18479-2
commit 815cf8f
Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
Date: Mon Jan 10 01:23:12 2022 +0100
Use directive binding in mdc-dialog demo for align
commit 77fca70
Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
Date: Mon Jan 10 01:20:43 2022 +0100
Change actionsAlignment type in dialog demo
commit c87c4aa
Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
Date: Mon Jan 10 00:21:57 2022 +0100
Revert weird changes to dialog.spec.ts
commit d6deb45
Author: Jean-Philippe <jeanphilippe.green@gmail.com>
Date: Sun Jan 9 23:30:24 2022 +0100
Use 'start' as default instead of undefined for align attribute in dialog actions
commit 8d367c1
Author: Jean-Philippe <jeanphilippe.green@gmail.com>
Date: Sun Jan 9 23:05:54 2022 +0100
Update comments in dialog.scss for more clarity
commit 9d2ac16
Merge: 54d0a60 3de4ab8
Author: Jean-Philippe <jeanphilippe.green@gmail.com>
Date: Sun Jan 9 22:33:13 2022 +0100
Merge branch 'angular:master' into align-attr-as-input-in-dialog-actions-#18479
commit 54d0a60
Merge: 462d407 c79e1d1
Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
Date: Wed Jan 5 21:30:29 2022 +0100
Merge branch 'angular-master' into align-attr-as-input-in-dialog-actions-#18479
commit c79e1d1
Merge: 462d407 03485cd
Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
Date: Wed Jan 5 21:23:17 2022 +0100
Merge branch 'master' of https://github.com/angular/components into angular-master
commit 462d407
Author: Jean-Philippe Green <jeanphilippe.green@gmail.com>
Date: Fri Dec 25 16:18:08 2020 +0100
fix(material-experimental/mdc-dialog): make align attr into an input of dialog actions directive
Fixes multiple issues, such as self-documentation of the align attribute, type checking, better
bindings, and IDE support. Because align is not standard for HTMLDivElement, it doesn't make much
sense to assume end users to know they can use the align attribute.
Fixes #18479 for material-experimental
commit c101f7f
Author: Jean-Philippe Green <jeanphilippe.green@gmail.com>
Date: Fri Dec 25 16:15:01 2020 +0100
fix(material/dialog): make align attribute into an input of dialog actions directive instead of css
Fixes multiple issues, such as self-documentation of the align attribute, type checking, better
bindings, and IDE support. Because align is not standard for HTMLDivElement, it doesn't make much
sense to assume end users to know they can use the align attribute.
Fixes #184791 parent a74d92e commit d7a9cbb
File tree
8 files changed
+61
-24
lines changed- src
- dev-app
- dialog
- mdc-dialog
- material-experimental/mdc-dialog
- material/dialog
8 files changed
+61
-24
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
24 | | - | |
| 24 | + | |
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
| |||
156 | 156 | | |
157 | 157 | | |
158 | 158 | | |
159 | | - | |
| 159 | + | |
160 | 160 | | |
161 | 161 | | |
162 | 162 | | |
| |||
177 | 177 | | |
178 | 178 | | |
179 | 179 | | |
180 | | - | |
| 180 | + | |
181 | 181 | | |
182 | 182 | | |
183 | 183 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
32 | | - | |
| 32 | + | |
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
| |||
173 | 173 | | |
174 | 174 | | |
175 | 175 | | |
176 | | - | |
| 176 | + | |
177 | 177 | | |
178 | 178 | | |
179 | 179 | | |
| |||
194 | 194 | | |
195 | 195 | | |
196 | 196 | | |
197 | | - | |
| 197 | + | |
198 | 198 | | |
199 | 199 | | |
200 | 200 | | |
| |||
Lines changed: 8 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
141 | 141 | | |
142 | 142 | | |
143 | 143 | | |
144 | | - | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
145 | 149 | | |
146 | | - | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
147 | 153 | | |
148 | 154 | | |
149 | 155 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
37 | 35 | | |
38 | 36 | | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
39 | 40 | | |
40 | 41 | | |
41 | 42 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1670 | 1670 | | |
1671 | 1671 | | |
1672 | 1672 | | |
| 1673 | + | |
| 1674 | + | |
| 1675 | + | |
| 1676 | + | |
| 1677 | + | |
| 1678 | + | |
| 1679 | + | |
| 1680 | + | |
| 1681 | + | |
| 1682 | + | |
| 1683 | + | |
1673 | 1684 | | |
1674 | 1685 | | |
1675 | 1686 | | |
| |||
2072 | 2083 | | |
2073 | 2084 | | |
2074 | 2085 | | |
2075 | | - | |
| 2086 | + | |
2076 | 2087 | | |
2077 | 2088 | | |
2078 | 2089 | | |
| |||
2091 | 2102 | | |
2092 | 2103 | | |
2093 | 2104 | | |
2094 | | - | |
| 2105 | + | |
2095 | 2106 | | |
2096 | 2107 | | |
2097 | 2108 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
145 | 145 | | |
146 | 146 | | |
147 | 147 | | |
148 | | - | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
149 | 153 | | |
150 | | - | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
151 | 157 | | |
152 | 158 | | |
153 | 159 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
56 | 56 | | |
57 | 57 | | |
58 | 58 | | |
59 | | - | |
60 | | - | |
61 | | - | |
62 | | - | |
63 | | - | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
64 | 62 | | |
65 | 63 | | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
66 | 67 | | |
67 | 68 | | |
68 | 69 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1733 | 1733 | | |
1734 | 1734 | | |
1735 | 1735 | | |
| 1736 | + | |
| 1737 | + | |
| 1738 | + | |
| 1739 | + | |
| 1740 | + | |
| 1741 | + | |
| 1742 | + | |
| 1743 | + | |
| 1744 | + | |
| 1745 | + | |
| 1746 | + | |
| 1747 | + | |
1736 | 1748 | | |
1737 | 1749 | | |
1738 | 1750 | | |
| |||
2116 | 2128 | | |
2117 | 2129 | | |
2118 | 2130 | | |
2119 | | - | |
| 2131 | + | |
2120 | 2132 | | |
2121 | 2133 | | |
2122 | 2134 | | |
| |||
2135 | 2147 | | |
2136 | 2148 | | |
2137 | 2149 | | |
2138 | | - | |
| 2150 | + | |
2139 | 2151 | | |
2140 | 2152 | | |
2141 | 2153 | | |
| |||
0 commit comments