Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #12245 does not seem to be part of the released package 6.4.1 #12386

Closed
benoitbzl opened this issue Jul 26, 2018 · 5 comments
Closed

Fix #12245 does not seem to be part of the released package 6.4.1 #12386

benoitbzl opened this issue Jul 26, 2018 · 5 comments
Assignees

Comments

@benoitbzl
Copy link

Bug:

The fix #12245 does not seem to be part of the generated npm package located at https://registry.npmjs.org/@angular/material/-/material-6.4.1.tgz (see function MatTabGroup.prototype.ngAfterContentInit function for example).

The release source archive does contain the fix.

What is the expected behavior?

What is the current behavior?

What are the steps to reproduce?

Providing a StackBlitz reproduction is the best way to share your issue.

StackBlitz starter: https://goo.gl/wwnhMV

What is the use-case or motivation for changing an existing behavior?

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Angular 6.1
Angular Material 6.4.1
Windows 10
Typescript 2.7.2
Chrome 67

Is there anything else we should know?

@devversion
Copy link
Member

Can reproduce that as well. (https://unpkg.com/@angular/material@6.4.1/bundles/material-tabs.umd.js).

@josephperrott can you have a look?

@michael-lang
Copy link

michael-lang commented Jul 26, 2018

Can also reproduce on the current documentation site:
https://material.angular.io/components/tabs/examples

demo, "Tab group with dynamically changing tabs". select the "select tab after editing" checkbox and then "Add new tab". The selected tab does not change.

Note, it does work occasionally as you edit the selected index textbox, but when the add button creates a tab and changes the selected tab index textbox, the tab does not change.

@josephperrott
Copy link
Member

It looks like something went wonky with our release process and the fix should be included in our next patch release.

@josephperrott
Copy link
Member

Closing as this change is included in 6.4.2

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants