Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

md-radio-button ripple effect #1449

Closed
joshterrill opened this issue Oct 7, 2016 · 5 comments
Closed

md-radio-button ripple effect #1449

joshterrill opened this issue Oct 7, 2016 · 5 comments
Assignees
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@joshterrill
Copy link

Bug, feature request, or proposal:

Bug

What is the expected behavior?

When you click a radio button, the ripple ripples and then you see it checked.

What is the current behavior?

When you click a radio button, it freezes at the beginning of the ripple and a yellow outlined circle is around it.

What are the steps to reproduce?

Plunkr: http://plnkr.co/edit/Psw6jjHvIHhWJRj6COfq?p=preview

What is the use-case or motivation for changing an existing behavior?

So it works the way it's supposed to!

Which versions of Angular, Material, OS, browsers are affected?

Angular version: 2.0.2
Material version: 2.0.0-alpha.9-3
OS: Mac OSX El Capitan
Browser: Chrome Version 53.0.2785.143 (64-bit)

Is there anything else we should know?

The material 1 radio button works as expected in the same browser and OS: https://material.angularjs.org/latest/demo/radioButton

Here's a screenshot of what it looks like on first click:

Imgur

Then once you click off of it or focus something else, it unfreezes the ripple effect.

@fxck
Copy link
Contributor

fxck commented Oct 7, 2016

Ripples are not quite done yet, this is more of a placeholder. #108

@joshterrill
Copy link
Author

What do you mean by that's more of a placeholder? Is there a way to add that to my radio button to make it work?

@mikekauffman
Copy link

Having the same problem. Is it possible to disable the broken effect until it's fixed. Radio buttons are not currently usable.

@jelbourn jelbourn added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label Oct 18, 2016
@tinayuangao
Copy link
Contributor

Fixed by #1553

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Development

No branches or pull requests

5 participants