Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(portal): TemplatePortal generic parameter #14602

Merged
merged 1 commit into from
May 13, 2019
Merged

fix(portal): TemplatePortal generic parameter #14602

merged 1 commit into from
May 13, 2019

Conversation

mina-skunk
Copy link
Contributor

issue #14584

@mina-skunk mina-skunk requested a review from jelbourn as a code owner December 20, 2018 23:58
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 20, 2018
@jelbourn jelbourn added target: patch This PR is targeted for the next patch release merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Dec 21, 2018
@jelbourn
Copy link
Member

I now realize that this is actually a breaking API change since it changes the signature of a public API, so it will have to wait to go in until v8.

@molayodecker
Copy link

molayodecker commented Mar 12, 2019 •
edited
Loading

Just want to know if there was anything wrong with this PR? Seems it needs more authorized users to revise it. @jelbourn

jelbourn
jelbourn approved these changes Mar 22, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Mar 22, 2019
@jelbourn
Copy link
Member

Caretaker: the commit message needs a breaking change block

@mmalerba mmalerba added aaa and removed aaa labels Apr 25, 2019
@jelbourn jelbourn merged commit 70bc4d5 into angular:master May 13, 2019
@mina-skunk mina-skunk deleted the template-portal-generic branch May 13, 2019 15:02
RudolfFrederiksen pushed a commit to RudolfFrederiksen/material2 that referenced this pull request Jun 21, 2019
@mina-skunk @RudolfFrederiksen
fix(portal): correct return type of TemplatePortal.attach (angular#14602
7a1584f 
)

Fixes angular#14584

BREAKING CHANGE
The return type of `TemplatePortal.attach` previously had an incorrect signature:
`TemplatePortal<C>.attach(...): C`. This should actually have been `TemplatePortal<C>.attach(...): EmbeddedViewRef<C>`. The type has been corrected.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mina-skunk @jelbourn @molayodecker @googlebot @mmalerba