fix(stepper): unable to skip step if completed value is overwritten #15403
Conversation
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
15310/stepper-completed-override
branch
from
1ece8b1 to
943ecf7
Compare
crisbeto
force-pushed
the
15310/stepper-completed-override
branch
3 times, most recently
from
ff7225c to
ffe1765
Compare
andrewseguin
added
the
P4
Currently we allow for the `completed` value of a step to be overwritten, however setting it to `true` still won't allow the user to skip the step, because the `interacted` flag won't be flipped if they haven't been on a particular step before. Fixes angular#15310.
crisbeto
force-pushed
the
15310/stepper-completed-override
branch
from
ffe1765 to
0e64c4b
Compare
| } | ||
| private _customCompleted: boolean | null = null; | ||
| _completedOverride: boolean|null = null; |
There was a problem hiding this comment.
is there a reason this was made non-private?
There was a problem hiding this comment.
It's been a long time since I opened this PR, but from what I can tell, it's because CdkStepper also checks it.
There was a problem hiding this comment.
Ah ok, yeah sorry was going through my old assigned PRs and found this that I never responded to
| } | ||
| private _customCompleted: boolean | null = null; | ||
| _completedOverride: boolean|null = null; |
There was a problem hiding this comment.
Ah ok, yeah sorry was going through my old assigned PRs and found this that I never responded to
mmalerba
added
pr: lgtm
action: merge
…15403) Currently we allow for the `completed` value of a step to be overwritten, however setting it to `true` still won't allow the user to skip the step, because the `interacted` flag won't be flipped if they haven't been on a particular step before. Fixes #15310. (cherry picked from commit bebb9ff)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Currently we allow for the
completedvalue of a step to be overwritten, however setting it totruestill won't allow the user to skip the step, because theinteractedflag won't be flipped if they haven't been on a particular step before.Fixes #15310.