Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(drag-drop): error if item is removed while dragging #15950

Merged
merged 1 commit into from
May 13, 2019

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented May 3, 2019

Fixes the drop list throwing an error if an item is removed after the user started dragging, because we still have it in the position cache.

Fixes #15827.

Fixes the drop list throwing an error if an item is removed after the user started dragging, because we still have it in the position cache.

Fixes angular#15827.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label May 3, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 3, 2019
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels May 8, 2019
@jelbourn jelbourn merged commit a632067 into angular:master May 13, 2019
RudolfFrederiksen pushed a commit to RudolfFrederiksen/material2 that referenced this pull request Jun 21, 2019
Fixes the drop list throwing an error if an item is removed after the user started dragging, because we still have it in the position cache.

Fixes angular#15827.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot read property "style" of null _rootElement - cdkDrag (drag-drop.es5.js)
3 participants