Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_updateElementSize should not fail if pane is disposed. #16600

Merged
merged 1 commit into from
Aug 21, 2019
Merged

_updateElementSize should not fail if pane is disposed. #16600

merged 1 commit into from
Aug 21, 2019

Conversation

mertdeg2
Copy link
Contributor

Note that this._pane will be set to null if the OverlayRef.dispose is called()

This could happen due to variety of reasons.

@mertdeg2
_updateElementSize should not fail if pane is disposed.
58d70d6 
Note that this._pane will be set to null if the OverlayRef.dispose is called()

This could happen due to variety of reasons.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 24, 2019
jelbourn
jelbourn approved these changes Jul 24, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jul 24, 2019
crisbeto
crisbeto approved these changes Jul 24, 2019
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can we write a unit test for it?

@andrewseguin andrewseguin merged commit a30270e into angular:master Aug 21, 2019
andrewseguin pushed a commit that referenced this pull request Aug 26, 2019
@mertdeg2 @andrewseguin
fix(overlay): _updateElementSize should not fail if pane is disposed. (…
febcaff 
…#16600)

Note that this._pane will be set to null if the OverlayRef.dispose is called()

This could happen due to variety of reasons.

(cherry picked from commit a30270e)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@jelbourn jelbourn jelbourn approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mertdeg2 @jelbourn @crisbeto @googlebot @andrewseguin