feat(material-experimental): test harness for dialog #16709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
blocked
devversion
requested review from
andrewseguin,
crisbeto,
jelbourn,
josephperrott and
mmalerba
as code owners
googlebot
added
the
cla: yes
Resolves COMP-180.
devversion
force-pushed
the
feat/test-harness-dialog
branch
from
796d802 to
54e030a
Compare
devversion
removed
the
blocked
devversion
added a commit
to devversion/material2
that referenced
this pull request
Aug 28, 2019
…nment Adds a new method that can be used by harness consumers to load a harness through `HarnessLoader` from the document root. This is helpful for harnesses which need to match elements outside of testbed fixtures (e.g. snack-bars, overlays etc.). Needed for angular#16697 and angular#16709.
devversion
added a commit
to devversion/material2
that referenced
this pull request
Aug 29, 2019
…s environment Adds a new method that can be used by harness consumers to load a harness through `HarnessLoader` from the document root. This is helpful for harnesses which need to match elements outside of testbed fixtures (e.g. snack-bars, overlays etc.). Needed for angular#16697 and angular#16709.
devversion
added a commit
to devversion/material2
that referenced
this pull request
Aug 29, 2019
…s environment Adds a new method that can be used by harness consumers to load a harness through `HarnessLoader` from the document root. This is helpful for harnesses which need to match elements outside of testbed fixtures (e.g. snack-bars, overlays etc.). Needed for angular#16697 and angular#16709.
jelbourn
added
pr: lgtm
action: merge
mmalerba
added a commit
to mmalerba/components
that referenced
this pull request
Sep 4, 2019
…essEnvironment` This should have been included as part of angular#16709, but got overlooked somehow
devversion
added a commit
to devversion/material2
that referenced
this pull request
Sep 5, 2019
…s environment Adds a new method that can be used by harness consumers to load a harness through `HarnessLoader` from the document root. This is helpful for harnesses which need to match elements outside of testbed fixtures (e.g. snack-bars, overlays etc.). Needed for angular#16697 and angular#16709.
devversion
added a commit
to devversion/material2
that referenced
this pull request
Sep 6, 2019
…s environment Adds a new method that can be used by harness consumers to load a harness through `HarnessLoader` from the document root. This is helpful for harnesses which need to match elements outside of testbed fixtures (e.g. snack-bars, overlays etc.). Needed for angular#16697 and angular#16709.
devversion
added a commit
to devversion/material2
that referenced
this pull request
Sep 6, 2019
…s environment Adds a new method that can be used by harness consumers to load a harness through `HarnessLoader` from the document root. This is helpful for harnesses which need to match elements outside of testbed fixtures (e.g. snack-bars, overlays etc.). Needed for angular#16697 and angular#16709.
devversion
added a commit
to devversion/material2
that referenced
this pull request
Sep 17, 2019
…s environment Adds a new method that can be used by harness consumers to load a harness through `HarnessLoader` from the document root. This is helpful for harnesses which need to match elements outside of testbed fixtures (e.g. snack-bars, overlays etc.). Needed for angular#16697 and angular#16709.
devversion
added a commit
to devversion/material2
that referenced
this pull request
Sep 17, 2019
…s environment Adds a new method that can be used by harness consumers to load a harness through `HarnessLoader` from the document root. This is helpful for harnesses which need to match elements outside of testbed fixtures (e.g. snack-bars, overlays etc.). Needed for angular#16697 and angular#16709.
devversion
added a commit
to devversion/material2
that referenced
this pull request
Sep 17, 2019
…s environment Adds a new method that can be used by harness consumers to load a harness through `HarnessLoader` from the document root. This is helpful for harnesses which need to match elements outside of testbed fixtures (e.g. snack-bars, overlays etc.). Needed for angular#16697 and angular#16709.
jelbourn
pushed a commit
to jelbourn/components
that referenced
this pull request
Sep 24, 2019
…s environment (angular#16903) Adds a new method that can be used by harness consumers to load a harness through `HarnessLoader` from the document root. This is helpful for harnesses which need to match elements outside of testbed fixtures (e.g. snack-bars, overlays etc.). Needed for angular#16697 and angular#16709. (cherry picked from commit 3765433)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves COMP-180.