Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(progress-spinner): rotating circle changing surrounding layout #16930

Merged
merged 1 commit into from
Nov 4, 2020
Merged

fix(progress-spinner): rotating circle changing surrounding layout #16930

merged 1 commit into from
Nov 4, 2020

Conversation

crisbeto
Copy link
Member

When the progress spinner is rotating its layout can outside that of the parent which can have an effect on scroll bars. These changes put the rotating animation on the svg node and make the component host overflow: hidden.

Fixes #16894.

@crisbeto crisbeto added P4 A relatively minor issue that is not relevant to core functions target: patch This PR is targeted for the next patch release labels Aug 31, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 31, 2019
jelbourn
jelbourn approved these changes Sep 4, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Sep 4, 2019
@ngbot
Copy link

ngbot bot commented Sep 4, 2019

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "ci/circleci: tests_browserstack" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@crisbeto crisbeto mentioned this pull request Sep 7, 2019
Closed
@crisbeto
fix(progress-spinner): rotating circle changing surrounding layout
ae742cb 
When the progress spinner is rotating its layout can outside that of the parent which can have an effect on scroll bars. These changes put the rotating animation on the `svg` node and make the component host `overflow: hidden`.

Fixes angular#16894.
@crisbeto crisbeto force-pushed the 16894/spinner-rotating-layout branch from b6ae845 to ae742cb Compare September 11, 2019 20:15
@josephperrott josephperrott removed their assignment Oct 15, 2019
@mmalerba mmalerba removed the lgtm label Jul 31, 2020
@alfaproject
Copy link

Is there any hope to move this forward? We've tried to use patch-package to apply this patch but for some reason it conflicts with ngcc and doesn't really work ):

@crisbeto
Copy link
Member Author

crisbeto commented Nov 3, 2020

For some reason I missed the comment from a couple of months ago. Bumping the priority.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent and removed P4 A relatively minor issue that is not relevant to core functions labels Nov 3, 2020
crisbeto added a commit to crisbeto/material2 that referenced this pull request Nov 3, 2020
@crisbeto
fix(material-experimental/mdc-progress-spinner): prevent animation fr…
9c80d69 
…om affecting surrounding layout

Similar to angular#16930. Prevents the indeterminate animation from overflowing the host node and affecting the page layout.
@crisbeto crisbeto mentioned this pull request Nov 3, 2020
Merged
@annieyw annieyw merged commit 930bc7e into angular:master Nov 4, 2020
annieyw pushed a commit that referenced this pull request Nov 4, 2020
@crisbeto @annieyw
fix(progress-spinner): rotating circle changing surrounding layout (#…
cbe8b5e 
…16930)

When the progress spinner is rotating its layout can outside that of the parent which can have an effect on scroll bars. These changes put the rotating animation on the `svg` node and make the component host `overflow: hidden`.

Fixes #16894.

(cherry picked from commit 930bc7e)
annieyw pushed a commit that referenced this pull request Nov 4, 2020
@crisbeto @annieyw
fix(progress-spinner): rotating circle changing surrounding layout (#…
87ccb98 
…16930)

When the progress spinner is rotating its layout can outside that of the parent which can have an effect on scroll bars. These changes put the rotating animation on the `svg` node and make the component host `overflow: hidden`.

Fixes #16894.

(cherry picked from commit 930bc7e)
wagnermaciel pushed a commit that referenced this pull request Nov 17, 2020
@crisbeto
fix(material-experimental/mdc-progress-spinner): prevent animation fr…
efd8ab6 
…om affecting surrounding layout (#20962)

Similar to #16930. Prevents the indeterminate animation from overflowing the host node and affecting the page layout.
wagnermaciel pushed a commit that referenced this pull request Nov 17, 2020
@crisbeto @wagnermaciel
fix(material-experimental/mdc-progress-spinner): prevent animation fr…
c598fe2 
…om affecting surrounding layout (#20962)

Similar to #16930. Prevents the indeterminate animation from overflowing the host node and affecting the page layout.

(cherry picked from commit efd8ab6)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@josephperrott josephperrott Awaiting requested review from josephperrott

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MatSpinner making scroll bars bounce
7 participants
@crisbeto @alfaproject @jelbourn @googlebot @josephperrott @mmalerba @annieyw