Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(icon): use ErrorHandler to log MatIcon errors #16999

Merged
merged 1 commit into from
Sep 13, 2019

Conversation

jelbourn
Copy link
Member

@jelbourn jelbourn commented Sep 6, 2019

This reverts commit 680ed00, which
reverted #16967 (roll forward)

cc @jermowery

This reverts commit 680ed00, which
reverted angular#16967 (roll forward)
@jelbourn jelbourn added pr: lgtm G This is is related to a Google internal issue target: patch This PR is targeted for the next patch release labels Sep 6, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 6, 2019
@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Sep 13, 2019
@jelbourn jelbourn merged commit 4778f49 into angular:master Sep 13, 2019
jelbourn added a commit to jelbourn/components that referenced this pull request Sep 24, 2019
This reverts commit 680ed00, which
reverted angular#16967 (roll forward)

(cherry picked from commit 4778f49)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement G This is is related to a Google internal issue target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants