Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/select): fix recursive call to SelectionModel.select() #17071

Merged
merged 1 commit into from
Sep 18, 2019
Merged

fix(material/select): fix recursive call to SelectionModel.select() #17071

merged 1 commit into from
Sep 18, 2019

Conversation

ogix
Copy link
Contributor

@ogix ogix commented Sep 13, 2019

Checks if option selection state in SelectionModel is different than the option selected value. Fixes "Maximum call stack size exceeded" error.

Fixes #12504

@ogix
fix(material/select): fix recursive call to SelectionModel.select()
aa19cf6 
Checks if option selection state in SelectionModel is different than the option selected value. Fixes "Maximum call stack size exceeded" error.
@ogix ogix requested a review from crisbeto as a code owner September 13, 2019 07:06
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 13, 2019
@ogix
Copy link
Contributor Author

ogix commented Sep 13, 2019

@crisbeto could you please review? It is a critical bug in our enterprise app.

crisbeto
crisbeto approved these changes Sep 14, 2019
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Sep 14, 2019
jelbourn
jelbourn approved these changes Sep 18, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit 14cdd89 into angular:master Sep 18, 2019
jelbourn pushed a commit to jelbourn/components that referenced this pull request Sep 24, 2019
@ogix @jelbourn
fix(material/select): fix recursive call to SelectionModel.select() (a…
ed96878 
…ngular#17071)

Checks if option selection state in SelectionModel is different than the option selected value. Fixes "Maximum call stack size exceeded" error.

(cherry picked from commit 14cdd89)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 19, 2019
@ogix ogix deleted the select-max-call-stack-fix branch August 6, 2020 07:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@jelbourn jelbourn jelbourn approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[mat-select] Maximum call stack size exceeded in select with 1000+ options
4 participants
@ogix @jelbourn @crisbeto @googlebot