fix(menu): keyboard controls not working if all items are disabled inside lazy content #17407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
googlebot
added
the
cla: yes
…side lazy content Fixes the menu's keyboard controls not working if it uses lazy content and all of the items are disabled. We did a similar fix in angular#16572, but I hadn't accounted for the fact that the items come in asynchronously when lazy content is used. Fixes angular#17400.
crisbeto
force-pushed
the
17400/menu-lazy-content-all-disabled
branch
from
91ebea1 to
c26428c
Compare
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the menu's keyboard controls not working if it uses lazy content and all of the items are disabled. We did a similar fix in #16572, but I hadn't accounted for the fact that the items come in asynchronously when lazy content is used.
Fixes #17400.