Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cdk/overlay): add transform origin selector as directive input #17489

Merged
merged 2 commits into from
Dec 3, 2019
Merged

feat(cdk/overlay): add transform origin selector as directive input #17489

merged 2 commits into from
Dec 3, 2019

Conversation

wenqi73
Copy link
Contributor

@wenqi73 wenqi73 commented Oct 24, 2019

No description provided.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 24, 2019
@wenqi73
Copy link
Contributor Author

wenqi73 commented Oct 24, 2019

Hi @jelbourn, could you please review this PR? I was confused about the error message

crisbeto
crisbeto approved these changes Oct 24, 2019
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The error message is because these changes add a new public API. You should run yarn bazel run //tools/public_api_guard:cdk/overlay.d.ts_api.accept --define=compile=legacy to generate a new public API file.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent pr: lgtm action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release labels Oct 24, 2019
@wenqi73
Copy link
Contributor Author

wenqi73 commented Oct 24, 2019

@crisbeto Thank you for your help!

jelbourn
jelbourn approved these changes Oct 24, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added target: patch This PR is targeted for the next patch release and removed target: minor This PR is targeted for the next minor release labels Dec 3, 2019
@jelbourn jelbourn merged commit c69a727 into angular:master Dec 3, 2019
@wenqi73 wenqi73 deleted the tranform-origin branch December 4, 2019 08:50
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@jelbourn jelbourn jelbourn approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wenqi73 @jelbourn @crisbeto @googlebot