fix(material-experimental/mdc-chips): use ripple target for state interactions #17681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewseguin
added
the
target: patch
googlebot
added
the
cla: yes
mmalerba
added
pr: lgtm
action: merge
mmalerba
approved these changes
Nov 12, 2019
crisbeto
reviewed
Nov 13, 2019
andrewseguin
force-pushed
the
mdc-chips-state
branch
from
d9d9129 to
4d91066
Compare
andrewseguin
force-pushed
the
mdc-chips-state
branch
from
4d91066 to
502c04f
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to what we did with button, checkbox. Use MDC's ripple target container for state interactions (focus, hover, active) rather than trying to do our own. This reduces our amount of overrides, aligns us better with their styles, fixes some bugs (e.g. the state color should match the text color, right now its always black), and helps us get it into using GM styles