feat(material/expansion): add test harness #17691
Merged
+669
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
the
target: minor
googlebot
added
the
cla: yes
devversion
force-pushed
the
feat/test-harness-expansion
branch
2 times, most recently
from
287bb98 to
fa3195a
Compare
mmalerba
reviewed
Nov 13, 2019
devversion
force-pushed
the
feat/test-harness-expansion
branch
from
dbdd00b to
3a77f5a
Compare
Adds a test harness for the Material expansion entry-point. Resolves COMP-204
devversion
force-pushed
the
feat/test-harness-expansion
branch
from
3a77f5a to
febf3d5
Compare
mmalerba
added
merge: caretaker note
|
CARETAKER NOTE: merge after 9.0 final |
jelbourn
reviewed
Nov 18, 2019
| * Toggles the expanded state of the panel by clicking on the panel | ||
| * header. This method will not work if the panel is disabled. | ||
| */ | ||
| async toggle(): Promise<void> { |
There was a problem hiding this comment.
In addition to toggle, I would add methods for expand and collapse that no-op if the panel is already expanded/collapsed
Address feedback
devversion
force-pushed
the
feat/test-harness-expansion
branch
from
2425315 to
d617b53
Compare
jelbourn
added
the
blocked
jelbourn
removed
the
blocked
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a test harness for the Material expansion entry-point. Resolves COMP-204