Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(input): avoid multiple autosize input listeners with ivy #17817

Merged
merged 1 commit into from
Dec 4, 2019
Merged

fix(input): avoid multiple autosize input listeners with ivy #17817

merged 1 commit into from
Dec 4, 2019

Conversation

crisbeto
Copy link
Member

Avoids double event listeners for the Material autosize directive, because Ivy merges inherited metadata, whereas ViewEngine overrides. We've made similar fixes in other places, but we probably missed this one because it doesn't break anything.

@crisbeto
fix(input): avoid multiple autosize input listeners with ivy
05ce5bc 
Avoids double event listeners for the Material autosize directive, because Ivy merges inherited metadata, whereas ViewEngine overrides. We've made similar fixes in other places, but we probably missed this one because it doesn't break anything.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Nov 26, 2019
@crisbeto crisbeto requested a review from mmalerba as a code owner November 26, 2019 20:55
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 26, 2019
jelbourn
jelbourn approved these changes Nov 27, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Nov 27, 2019
@jelbourn jelbourn merged commit fe151e6 into angular:master Dec 4, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crisbeto @jelbourn @googlebot