-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(expansion): add strong focus indication #18552
Conversation
@zelliott PTAL |
@crisbeto The reason we removed the expansion panel header focus indicators from the master focus indicators PR (8a44fb9) was because adding The TL;DR is when an expansion panel header has a non-transparent background & No
We tried to fix this layering issue by adding I think a more involved CSS fix will be needed to make these expansion panel headers relatively positioned... |
@crisbeto Try adding a non-transparent background to the headers? The headers have a transparent background by default, so the layering has no visual effect. |
Since the color contrast on the expansion panel focus state isn't great, it's a good candidate to have strong focus indication.
583772a
to
879c4d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Since the color contrast on the expansion panel focus state isn't great, it's a good candidate to have strong focus indication.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Since the color contrast on the expansion panel focus state isn't great, it's a good candidate to have strong focus indication.