Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(slider): not stopping drag when released outside of viewport #18905

Merged
merged 1 commit into from
Mar 31, 2020
Merged

fix(slider): not stopping drag when released outside of viewport #18905

merged 1 commit into from
Mar 31, 2020

Conversation

crisbeto
Copy link
Member

We're binding the slider events to the document.body which means that we won't pick up the ones that happen outside the viewport. These changes move the events to the document.

Fixes #18888.

@crisbeto
fix(slider): not stopping drag when released outside of viewport
59f7f6e 
We're binding the slider events to the `document.body` which means that we won't pick up the ones that happen outside the viewport. These changes move the events to the `document`.

Fixes angular#18888.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Mar 24, 2020
@crisbeto crisbeto requested a review from mmalerba as a code owner March 24, 2020 17:21
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 24, 2020
mmalerba
mmalerba approved these changes Mar 25, 2020
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added lgtm action: merge The PR is ready for merge by the caretaker labels Mar 25, 2020
@jelbourn jelbourn merged commit 1718d78 into angular:master Mar 31, 2020
jelbourn pushed a commit that referenced this pull request Apr 6, 2020
@crisbeto @jelbourn
fix(slider): not stopping drag when released outside of viewport (#18905
ca3c68f 
)

We're binding the slider events to the `document.body` which means that we won't pick up the ones that happen outside the viewport. These changes move the events to the `document`.

Fixes #18888.

(cherry picked from commit 1718d78)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(MatSlider): the slider remains focused when dragging out of the window and back again.
4 participants
@crisbeto @mmalerba @jelbourn @googlebot