Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(popover-edit): hover content not showing up if content changes after init #18937

Merged
merged 1 commit into from
Mar 31, 2020
Merged

fix(popover-edit): hover content not showing up if content changes after init #18937

merged 1 commit into from
Mar 31, 2020

Conversation

crisbeto
Copy link
Member

If the table's content changes after the first render, the popover edit wasn't showing up on hover, because some of the new subscribers weren't getting the previous value. These changes fix the issue by using shareReplay instead of share.

Fixes #18934.

@crisbeto
fix(popover-edit): hover content not showing up if content changes af…
6e44527 
…ter init

If the table's content changes after the first render, the popover edit wasn't showing up on hover, because some of the new subscribers weren't getting the previous value. These changes fix the issue by using `shareReplay` instead of `share`.

Fixes angular#18934.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge safe target: patch This PR is targeted for the next patch release labels Mar 28, 2020
@crisbeto crisbeto requested a review from andrewseguin as a code owner March 28, 2020 11:41
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 28, 2020
jelbourn
jelbourn approved these changes Mar 30, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added lgtm action: merge The PR is ready for merge by the caretaker labels Mar 30, 2020
@jelbourn jelbourn merged commit f70f49a into angular:master Mar 31, 2020
jelbourn pushed a commit that referenced this pull request Mar 31, 2020
@crisbeto @jelbourn
fix(popover-edit): hover content not showing up if content changes af…
d7ff7cb 
…ter init (#18937)

If the table's content changes after the first render, the popover edit wasn't showing up on hover, because some of the new subscribers weren't getting the previous value. These changes fix the issue by using `shareReplay` instead of `share`.

Fixes #18934.

(cherry picked from commit f70f49a)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees

@jelbourn jelbourn

@kseamon kseamon

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug([CdkPopoverEdit]): [cdkRowHoverContent not displayed when table dataSource changes]
4 participants
@crisbeto @jelbourn @kseamon @googlebot