fix(datepicker): add hover indication to navigation buttons #18995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The calendar navigation buttons use `mat-icon-button` which explicitly doesn't have hover indication for some reason (see https://github.com/angular/components/blob/master/src/material/button/button.scss#L13). I'm not exactly sure about the reasoning in `mat-button`, so I decided to scope these changes only to the calendar so we don't cause unexpected behavior. Fixes angular#18958.
crisbeto
added
P3
googlebot
added
the
cla: yes
mmalerba
pushed a commit
that referenced
this pull request
Apr 14, 2020
The calendar navigation buttons use `mat-icon-button` which explicitly doesn't have hover indication for some reason (see https://github.com/angular/components/blob/master/src/material/button/button.scss#L13). I'm not exactly sure about the reasoning in `mat-button`, so I decided to scope these changes only to the calendar so we don't cause unexpected behavior. Fixes #18958.
This was referenced May 3, 2020
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The calendar navigation buttons use
mat-icon-buttonwhich explicitly doesn't have hover indication for some reason (see https://github.com/angular/components/blob/master/src/material/button/button.scss#L13). I'm not exactly sure about the reasoning inmat-button, so I decided to scope these changes only to the calendar so we don't cause unexpected behavior.Fixes #18958.