Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(material-experimental/mdc-list): add MDC foundation for action/nav list #19601

Merged
merged 10 commits into from
Jun 19, 2020

Conversation

mmalerba
Copy link
Contributor

Note: still need to add support for selection list in a future PR

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 10, 2020
@mmalerba mmalerba added P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Jun 10, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 10, 2020
@mmalerba mmalerba force-pushed the mdc-select-list-2 branch from fca1b72 to 48f4f15 Compare June 11, 2020 21:14
@mmalerba mmalerba force-pushed the mdc-select-list-2 branch from 868aa88 to 6c026d2 Compare June 12, 2020 17:55
Copy link
Contributor Author

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feedback addressed, PTAL

Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One minor nit/question.

src/material-experimental/mdc-list/list-base.ts Outdated Show resolved Hide resolved
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/material-experimental/mdc-list/list-base.ts Outdated Show resolved Hide resolved
@jelbourn jelbourn added the lgtm label Jun 16, 2020
@mmalerba mmalerba force-pushed the mdc-select-list-2 branch from 0741b56 to 287a588 Compare June 19, 2020 18:16
@mmalerba mmalerba added action: merge The PR is ready for merge by the caretaker merge safe labels Jun 19, 2020
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba merged commit 166bb52 into angular:master Jun 19, 2020
mmalerba added a commit that referenced this pull request Jun 19, 2020
…av list (#19601)

* feat(material-expeirmental/mdc-list): add support for focus/hover states
and ripples

* add state styles

* add adapter for MDCList

* set up MDCListFoundation

* refactor so only interactive lists set up the foundation

* address feedback

* use descendants:true for content children

* don't change tabindex on child elements of list-item

* fix tabIndex initialization

* move logic out of lifecycle hooks
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants