-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(material-experimental/mdc-list): add MDC foundation for action/nav list #19601
Conversation
fca1b72
to
48f4f15
Compare
868aa88
to
6c026d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feedback addressed, PTAL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. One minor nit/question.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
0741b56
to
287a588
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…av list (#19601) * feat(material-expeirmental/mdc-list): add support for focus/hover states and ripples * add state styles * add adapter for MDCList * set up MDCListFoundation * refactor so only interactive lists set up the foundation * address feedback * use descendants:true for content children * don't change tabindex on child elements of list-item * fix tabIndex initialization * move logic out of lifecycle hooks
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Note: still need to add support for selection list in a future PR