Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(toolbar): Better theming #19969

Closed
tomasdev opened this issue Jul 14, 2020 · 2 comments
Closed

feat(toolbar): Better theming #19969

tomasdev opened this issue Jul 14, 2020 · 2 comments
Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix needs triage This issue needs to be triaged by the team

Comments

@tomasdev
Copy link

tomasdev commented Jul 14, 2020

Feature Description

It would be great if theming was simpler overall. But specifically for the mat-toolbar component, the SASS looks convoluted to be able to just change the background color to something other than the accent/primary/warn settings.

Proposed Solution

Instead of having to do

@include mat-toolbar-theme(
  map_merge(
    $theme, (
      background: map_merge(
        map-get($theme, background), (
          app-bar: #fff,
        )
      )
    )
  )
);

Have something like:

@include mat-toolbar-theme($theme, (app-bar: #fff));

Implementation can vary widely, but overall I'd like to have mat-toolbar-theme($theme, $extra... = ()) for extensibility.

Looking forward to reading your thoughts!

@tomasdev tomasdev added feature This issue represents a new feature or feature request rather than a bug or bug fix needs triage This issue needs to be triaged by the team labels Jul 14, 2020
@tomasdev
Copy link
Author

Duplicate of #6244

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix needs triage This issue needs to be triaged by the team
Projects
None yet
Development

No branches or pull requests

1 participant