Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cdk/testing): fix change detection timing in testbed #20465

Merged
merged 1 commit into from
Sep 1, 2020
Merged

fix(cdk/testing): fix change detection timing in testbed #20465

merged 1 commit into from
Sep 1, 2020

Conversation

mmalerba
Copy link
Contributor

change detection should be triggered before reading element state and after interacting with an element

@mmalerba mmalerba added the target: patch This PR is targeted for the next patch release label Aug 31, 2020
@mmalerba mmalerba requested a review from crisbeto August 31, 2020 22:52
@mmalerba mmalerba requested a review from devversion as a code owner August 31, 2020 22:52
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 31, 2020
crisbeto
crisbeto approved these changes Sep 1, 2020
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Sep 1, 2020
@mmalerba mmalerba added the P2 The issue is important to a large percentage of users, with a workaround label Sep 1, 2020
@mmalerba mmalerba merged commit e01fac4 into angular:master Sep 1, 2020
mmalerba added a commit that referenced this pull request Sep 1, 2020
@mmalerba
fix(cdk/testing): fix change detection timing in testbed (#20465)
addf142 
(cherry picked from commit e01fac4)
mmalerba added a commit that referenced this pull request Sep 2, 2020
@mmalerba
fix(cdk/testing): fix change detection timing in testbed (#20465)
29468fa
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@devversion devversion Awaiting requested review from devversion

Assignees

@crisbeto crisbeto

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmalerba @crisbeto @googlebot