fix(material-experimental/mdc-button): fix positioning of icons in text buttons #20963
Conversation
mmalerba
added
P2
google-cla
bot
added
the
cla: yes
mmalerba
changed the title
| // will extend the `mdc-button__icon` styling to the mat icon. Note that | ||
| // the extended styles inherently only match icons that nest themselves in | ||
| // a parent `mdc-button`. | ||
| .mat-icon { |
There was a problem hiding this comment.
Should this be constrained to only mat-icon inside of mat-icon-button?
There was a problem hiding this comment.
We seem to have an identical issue in the FAB. I've submitted #20969 to address it.
There was a problem hiding this comment.
Yeah I may have copy/pasted this from fab 😅
There was a problem hiding this comment.
Still looks like this needs to be changed?
There was a problem hiding this comment.
Sorry, forgot to push
| <button mat-stroked-button> | ||
| <mat-icon>home</mat-icon> | ||
| with icons | ||
| <mat-icon iconPositionEnd>favorite</mat-icon> |
There was a problem hiding this comment.
Should the selector be prefixed with mat?
There was a problem hiding this comment.
This is a pre-existing API, I'm just using it in this demo
|
Comments addressed |
mmalerba
force-pushed
the
mdc-button-icon
branch
from
aa7c5f6 to
d36e380
Compare
mmalerba
added
target: patch
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Here's how it looks with the fix:
