fix(cdk/accordion): allow for closeAll to be used when multiple mode is disabled #22055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is disabled Currently `CdkAccordion.closeAll` only works if `multi` is set to false, however it makes sense when a single item is expanded as well. These changes also fix that `_openCloseAllActions` wasn't being completed and they include more unit tests. Fixes angular#22003.
crisbeto
added
P3
google-cla
bot
added
the
cla: yes
wagnermaciel
pushed a commit
that referenced
this pull request
Mar 2, 2021
…is disabled (#22055) Currently `CdkAccordion.closeAll` only works if `multi` is set to false, however it makes sense when a single item is expanded as well. These changes also fix that `_openCloseAllActions` wasn't being completed and they include more unit tests. Fixes #22003. (cherry picked from commit a41fb6e)
This was referenced Mar 6, 2021
This was referenced Mar 17, 2021
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
CdkAccordion.closeAllonly works ifmultiis set to false, however it makes sense when a single item is expanded as well.These changes also fix that
_openCloseAllActionswasn't being completed and they include more unit tests.Fixes #22003.