Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(material-experimental/mdc-button): add default config for FAB #22102

Merged
merged 1 commit into from
Mar 9, 2021

Conversation

annieyw
Copy link
Contributor

@annieyw annieyw commented Mar 3, 2021

Add default config for FAB with color so the default accent color can be overwritten if needed

@annieyw annieyw added P2 The issue is important to a large percentage of users, with a workaround G This is is related to a Google internal issue labels Mar 3, 2021
@annieyw annieyw requested a review from andrewseguin March 3, 2021 21:23
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 3, 2021
@annieyw annieyw force-pushed the fab-default-options branch 3 times, most recently from e6958f1 to 8182fd9 Compare March 3, 2021 21:58
@annieyw annieyw requested a review from mmalerba March 3, 2021 21:58
@annieyw
Copy link
Contributor Author

annieyw commented Mar 4, 2021

@andrewseguin Do you have more context on view engine issues with providers?

@annieyw annieyw force-pushed the fab-default-options branch from 8182fd9 to 9851927 Compare March 4, 2021 23:43
@annieyw
Copy link
Contributor Author

annieyw commented Mar 5, 2021

Fixed View Engine error. Would this be a patch or minor? It's adding a new interface but not changing any existing behavior

Copy link
Contributor

@andrewseguin andrewseguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor seems appropriate

};
}

// Default checkbox configuration.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"checkbox" -> "FAB"

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement G This is is related to a Google internal issue P2 The issue is important to a large percentage of users, with a workaround target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants