Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/core): update mixin functions to avoid unknown cast #22577

Merged
merged 1 commit into from
May 3, 2021
Merged

fix(material/core): update mixin functions to avoid unknown cast #22577

merged 1 commit into from
May 3, 2021

Conversation

crisbeto
Copy link
Member

Reworks the mixin functions in order to remove a workaround where we had to cast to unknown. The cast was causing some issues with Closure compiler.

@crisbeto
fix(material/core): update mixin functions to avoid unknown cast
60c168c 
Reworks the mixin functions in order to remove a workaround where we had to cast to `unknown`. The cast was causing some issues with Closure compiler.
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 27, 2021
@crisbeto crisbeto requested a review from jelbourn April 27, 2021 17:09
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: rc This PR is targeted for the next release-candidate labels Apr 27, 2021
@crisbeto crisbeto marked this pull request as ready for review April 27, 2021 17:09
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Apr 28, 2021
@annieyw annieyw merged commit d92f8f2 into angular:master May 3, 2021
annieyw pushed a commit that referenced this pull request May 3, 2021
@crisbeto @annieyw
fix(material/core): update mixin functions to avoid unknown cast (#22577
33104b6 
)

Reworks the mixin functions in order to remove a workaround where we had to cast to `unknown`. The cast was causing some issues with Closure compiler.

(cherry picked from commit d92f8f2)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crisbeto @devversion @annieyw