-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Icon Toggle [new component request] #2375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@fxck Yes, maybe an icon toggle can be implemented using exclusive selection button groups, but it seems wired to me (a group with only one element and two level html markup. I'd prefer something like |
How would edit: updated plunk |
MDC implementation is not following the material design spec (no outlines) - |
Well, It's really wired. https://material.io/components/ links to https://github.com/material-components/material-components-web#useful-links. If you follow the Demos link you will reach the Icon Toggle demo I've post. Seems that MDC Icon Toggle was made by the same guys that write Material Design Spec. |
Well, https://material.io/components/ is the website for https://github.com/material-components/material-components-web#useful-links. They're not the same guys and even if they're, if its not in the spec, we won't implement it. |
But, what's the official Material spec? Are you saying that people who write https://material.io/guidelines are not the same that people who implement https://material.io/components? Why both projects share material.io domain if they don't follow the same spect? Sorry, for dumb questions, but it's confusing. |
Yes, just as the people that write material.angular.io are not the same as augury.angular.io |
I am confused @EladBezalel
I visited the link you shared and Icon toggles is included in the material design spec as part of the Toggle buttons section, so I think that something like |
I'm talking about outlining the icon itself, this part is not included in the material design spec. You can totally have icon buttons as simple as: <button mdIconButton>
<md-icon>my_icon</md-icon>
</button> |
Ok @EladBezalel, but what about the ripple ink response? The ripple ink boundary seems to be different (out of boundaries) to icon toggles than the regular icon button. |
@EladBezalel, thanks!!! |
I know this is super old, but @EladBezalel or others, as far as I can tell there's still no official implementation of "Icon Toggle" from the spec. Yes, you can hack in behavior for a toggle based on Since icon toggles are in the spec, I would suggest that they should have an example in the docs (and, ideally, easy to use syntax). |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Uh oh!
There was an error while loading. Please reload this page.
Would be great to include icon toggles as defined in https://material.io/guidelines/components/buttons.html#buttons-toggle-buttons
MDC has a nice implementation of this
https://material-components-web.appspot.com/icon-toggle.html
The text was updated successfully, but these errors were encountered: