Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention that <!DOCTYPE html> is required in getting started docs #2832

Closed
alexsapps opened this issue Jan 27, 2017 · 2 comments
Closed

Mention that <!DOCTYPE html> is required in getting started docs #2832

alexsapps opened this issue Jan 27, 2017 · 2 comments

Comments

@alexsapps
Copy link

Bug, feature request, or proposal:

Mention that page must have <!DOCTYPE html> for Material components to render properly as HTML 5. Just a suggestion.
here: https://github.com/angular/material2/blob/master/guides/getting-started.md
and here: https://material.angular.io/guide/getting-started
(not sure why there are two getting started guides)

What is the use-case or motivation for changing an existing behavior?

This problem with dialogs is hard to troubleshoot:
#2351

In general when something isn't displaying right, DOCTYPE makes for an insidious culprit. You have to wonder if you're including the right CSS, check all your own CSS, and post stackoverflow questions or github issues, or maybe just add your own CSS hacks to patch up the problem before thinking to double check your DOCTYPE.

@crisbeto
Copy link
Member

crisbeto commented Jan 27, 2017

I'm not sure that it belongs in the getting started guide, but I was going to log a warning in dev mode, if you're missing it, I just haven't gotten around to adding it yet. Closing since this is being tracked via #2351.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants