-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Proposal: Not remove MaterialModule in next release #4261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This should be fixed with 76faae5. Can you try installing |
I did, but unfortunately the results did not vary. Probably webpack fault. There is a huge discussion about this pure annotation thing. |
There's another issue tracked in #4137 about webpack not being able to do this. We're working on something now to fix this; MaterialModule is still going to go away, but only once the benefit applies without a lot of extra work. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Bug, feature request, or proposal: Proposal
Just today I've replaced all MaterialModules with more specific module in my whole application, for example:
What is the expected behavior?
For a medium sized application I expected some decrease in application size as I don't use all modules.
Before: https://ibb.co/eaw0wQ
After: https://ibb.co/fcR0wQ
What is the current behavior?
The application size did almost not change - really insignificant decrease, few kb. I guess that with es5 modules UglifyJS does good enough job for the change to have any impact. Or maybe even direct imports is not enough to weed out unnecessary parts of code.
Maybe it's just my specific setup (angular2-webpack-starter type). Did you experience any difference after switching to more specific imports?
What are the steps to reproduce?
If anyone interested in replicating the result:
https://bitbucket.org/kmierzej/fragaria-webapp/commits/6c78b86731c4e59d2a0527ed7ccdbe5737f72563
The text was updated successfully, but these errors were encountered: