Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moduleId: module.id is undefined if material 2 alpha.5 is loaded as umd instead of system.js #540

Closed
gregbown opened this issue May 27, 2016 · 4 comments

Comments

@gregbown
Copy link

I am curious, what is the purpose of having this moduleId property on every component as of alpha.5?

It appears that module.id is the path to the application component at run time if the application is loaded via system.js. Is there any intention of supporting other use cases such as loading material in a umd fashion?

I am loading the modules in a umd format, therefore module.id is undefined. My only solution was to comment out //moduleId: module.id in the components.

Thank you
Greg

@jelbourn
Copy link
Member

Publishing umd bundles for the components is on our to-do list.

@hansl: is this something that falls under the CLI umbrella or something we should do on our own?

@hansl
Copy link
Contributor

hansl commented May 27, 2016

We'll have to do it on our own.

@gregbown: module.id allows us to put the templates as relative paths. Since the templates are inlined in Material before publishing, it's safe to remove.

@jelbourn: Maybe we can just remove the module.id prior to publishing.

@gregbown
Copy link
Author

Thank you for the clarification and prompt response @hansl & @jelbourn.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants