Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "fix(dialog,bottom-sheet): enter animation blocking child anim… #14017

Merged
merged 1 commit into from
Nov 7, 2018
Merged

Revert "fix(dialog,bottom-sheet): enter animation blocking child anim… #14017

merged 1 commit into from
Nov 7, 2018

Conversation

jelbourn
Copy link
Member

@jelbourn jelbourn commented Nov 7, 2018

…ations (#13888)"

This reverts commit 235add9.

This change broke an app inside of Google where tabs appear inside of a
dialog. The tabs get stuck in a weird frozen animation state.

@jelbourn
Revert "fix(dialog,bottom-sheet): enter animation blocking child anim…
442e708 
…ations (angular#13888)"

This reverts commit 235add9.

This change broke an app inside of Google where tabs appear inside of a
dialog. The tabs get stuck in a weird frozen animation state.
@jelbourn jelbourn added the target: patch This PR is targeted for the next patch release label Nov 7, 2018
@jelbourn jelbourn requested a review from vivian-hu-zz November 7, 2018 01:01
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 7, 2018
vivian-hu-zz
vivian-hu-zz approved these changes Nov 7, 2018
View reviewed changes
Copy link
Contributor

@vivian-hu-zz vivian-hu-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vivian-hu-zz vivian-hu-zz merged commit d50b9f2 into angular:master Nov 7, 2018
vivian-hu-zz pushed a commit that referenced this pull request Nov 12, 2018
@jelbourn
Revert "fix(dialog,bottom-sheet): enter animation blocking child anim…
53c9649 
…ations (#13888)" (#14017)

This reverts commit 235add9.

This change broke an app inside of Google where tabs appear inside of a
dialog. The tabs get stuck in a weird frozen animation state.
@virtuoushub virtuoushub mentioned this pull request Nov 28, 2018
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vivian-hu-zz vivian-hu-zz vivian-hu-zz approved these changes

@crisbeto crisbeto Awaiting requested review from crisbeto

@josephperrott josephperrott Awaiting requested review from josephperrott

Assignees
No one assigned
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jelbourn @vivian-hu-zz @googlebot