feat(overlay-directives): support fallback positions #1865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
reviewed
Nov 16, 2016
| } | ||
|
|
||
| this._positionSubscription = strategy.onPositionChange.subscribe( | ||
| (pos: ConnectedOverlayPositionChange) => { |
There was a problem hiding this comment.
This type shouldn't be necessary since it's in the generic, no? Then you could do
this._positionSubscription =
strategy.onPositionChange.subscribe(pos => this.positionChange.emit(pos));
kara
force-pushed
the
select-fallback
branch
from
9734ed8
to
5d941e7
Compare
|
@jelbourn Updated the PR to address the comment! |
|
LGTM |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for fallback positions and position change events to the overlay directives.
r: @jelbourn