refactor: remove empty harness e2e stylesheet #25304
Conversation
alkavats1
force-pushed
the
codeSmells-removed
branch
2 times, most recently
from
c10ff75 to
abbdbf7
Compare
|
The commit message and description is not helpful. Please modify it to describe this change |
alkavats1
force-pushed
the
codeSmells-removed
branch
from
abbdbf7 to
b095614
Compare
|
I've modified the commit message. Please review it |
|
The commit message refers to "code smells" - this is vague and still isn't helpful. I am expecting something more like "refactor: remove empty harness e2e stylesheet". Also, your change is adding an unnecessary line to the mdc-migration Can you help me understand more about why you are making this change? Is this practice contributing a pull request? |
alkavats1
force-pushed
the
codeSmells-removed
branch
from
b095614 to
0f7fb0d
Compare
removed the empty files to remove the code smells from the code
alkavats1
force-pushed
the
codeSmells-removed
branch
from
0f7fb0d to
b179ef7
Compare
|
@andrewseguin Is it fine now? |
andrewseguin
changed the title
andrewseguin
added
the
target: patch
removed the empty files to remove the code smells from the code (cherry picked from commit 2905638)
removed the empty files to remove the code smells from the code (cherry picked from commit 2905638)
|
FYI that this was a default CLI app generated and it was meant to keep the same boilerplate. I'm good with this change though as I don't see any issue here. Still wanted to mention that this is intentional though. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
3 participants
No description provided.