-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(input): make input spacing match spec #4788
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
bd74d52
make input match mocks better, WIP
mmalerba e94a7d0
add select to baseline demo
mmalerba b29b97b
fix IE bug
mmalerba abb8e60
address comments
mmalerba c877cb9
address comments
mmalerba a088b2c
remove forced font-size
mmalerba 13647fc
integrate typography system
mmalerba 4f4f94b
switch font-size to inherit
mmalerba 886025d
fix non-floating placeholders
mmalerba File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,7 @@ | ||
<div class="mat-input-wrapper"> | ||
<div class="mat-input-table"> | ||
<div class="mat-input-flex"> | ||
<div class="mat-input-prefix" *ngIf="_prefixChildren.length"> | ||
<!-- TODO(andrewseguin): remove [md-prefix] --> | ||
<ng-content select="[mdPrefix], [matPrefix], [md-prefix]"></ng-content> | ||
<ng-content select="[mdPrefix], [matPrefix]"></ng-content> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There are three use sites for There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'll fix them |
||
</div> | ||
|
||
<div class="mat-input-infix" [class.mat-end]="align == 'end'"> | ||
|
@@ -24,8 +23,7 @@ | |
</div> | ||
|
||
<div class="mat-input-suffix" *ngIf="_suffixChildren.length"> | ||
<!-- TODO(andrewseguin): remove [md-suffix] --> | ||
<ng-content select="[mdSuffix], [matSuffix], [md-suffix]"></ng-content> | ||
<ng-content select="[mdSuffix], [matSuffix]"></ng-content> | ||
</div> | ||
</div> | ||
|
||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't cause a stylelint error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope, seems fine