Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace benchmark concatjs devserver instance with custom devserver #318

Open
devversion opened this issue Dec 1, 2021 · 1 comment
Open
Assignees

Comments

@devversion
Copy link
Member

The ConcatJS devserver in rules_nodejs seems to not work with with M1 Apple, neither does it work with Windows anymore. The Windows breakage seems to have started with recent runfile resolution changes there.

We should be using the Windows-compatible and less magical devserver that we maintain in Angular Components.

Target //bazel/benchmark/component_benchmark/test:test_server up-to-date:
  dist/bin/bazel/benchmark/component_benchmark/test/test_server_launcher.sh
  dist/bin/bazel/benchmark/component_benchmark/test/test_server
  dist/bin/bazel/benchmark/component_benchmark/test/test_server.exe
INFO: Elapsed time: 1.077s, Critical Path: 0.02s
INFO: 4 processes: 4 internal.
INFO: Build completed successfully, 4 total actions
INFO: Build completed successfully, 4 total actions
Could not find runfile dev-infra/../npm/node_modules/zone.js/bundles/zone.umd.js, got error Runfile ../npm/node_modules/zone.js/bundles/zone.umd.js: could not locate fileFailed to read script dev-infra/../npm/node_modules/zone.js/bundles/zone.umd.js: open : The system cannot find the file specified.
Could not find runfile dev-infra/../npm/@bazel/concatjs/third_party/npm/requirejs/require.js, got error Runfile ../npm/@bazel/concatjs/third_party/npm/requirejs/require.js: could not locate fileFailed to read script dev-infra/../npm/@bazel/concatjs/third_party/npm/requirejs/require.js: open : The system cannot find the file specified.
Server listening on http://paul-windows:4200/
@devversion devversion self-assigned this Dec 1, 2021
@devversion
Copy link
Member Author

This is done in COMP and this repo. There are some leftovers in FW that need to switch for M1 support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant