-
Notifications
You must be signed in to change notification settings - Fork 56
Set up Windows CI #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Windows CI is set up on Framework and CLI |
Closing as windows CI is not needed for components |
(Wat? Everyone needs some Windows CI in their life 😕) I just wanted to mention that one benefit of having Windows set up on CI is ensuring that the project can be built/tested on Windows. Many potential contributors use Windows and being able to build/test the project is essential to being able to contribute. Having build processes that do not work on Windows is another factor that makes it difficult for many people to get involved. (It kind of scares me to think that I would probably not have gotten into contibuting to Angular if I started today, because building/testing on Windows is...what it is 😁 😱 😢) I just wanted to make sure we also keep that dimension in mind |
You are definitely right that testing our projects against windows is important. I will expand on what I meant here. And want to be sure to note that if we determine that a windows executor on CI for components makes sense we will definitely set it up. We currently don't think that windows CI is needed for components as the components repository does not do anything that relies on the file system in windows. This is specifically in contrast to Framework and CLI which interact with the file system and have to make choices that are file system specific. The OS specific effects for components instead lies in browser specific testing. Either because the layout/JS engines would be somehow different on a specific OS or because some browsers are only available on a specific OS. We address this concern for components using BrowserStack/SauceLabs to run our tests in specific browsers. |
Thx for adding more details about the reasoning. Capturing that kind of context is always useful for future reference 👍 Just to make sure my previous comment was clear: What I meant is that there are mainly two benefits/reasons for testing a project against a specific OS on CI:
So, I was pointing out that there is this second reason why it might be worth setting up Windows CI, even for projects that would not benefit from the first reason. Of course, before setting up Windows CI, one needs to make the dev workflow compatible with Windows (and I understand that's a separate issue/work) 😁 |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
The text was updated successfully, but these errors were encountered: