fix(tabs): prevents error when navigating away from tabs section whil…

…e using Angular 1.4.x
angular · Jul 17, 2015 · 31bb121 · 31bb121
1 parent 7bbfd1f
commit 31bb121
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/components/tabs/js/tabsController.js b/src/components/tabs/js/tabsController.js
@@ -348,12 +348,13 @@ function MdTabsController ($scope, $element, $window, $mdConstant, $mdTabInkRipp
  * @param tabData
  */
  function removeTab (tabData) {
+ if (destroyed) return;
  var selectedIndex = ctrl.selectedIndex,
  tab = ctrl.tabs.splice(tabData.getIndex(), 1)[ 0 ];
  refreshIndex();
  // when removing a tab, if the selected index did not change, we have to manually trigger the
  // tab select/deselect events
- if (ctrl.selectedIndex === selectedIndex && !destroyed) {
+ if (ctrl.selectedIndex === selectedIndex) {
  tab.scope.deselect();
  ctrl.tabs[ ctrl.selectedIndex ] && ctrl.tabs[ ctrl.selectedIndex ].scope.select();
  }