Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Commit 5dbcaa6

Browse files
author
Robert Messerle
committed
fix(slider): updates positioning method to prevent overflow issues
Closes #1343
1 parent d70094d commit 5dbcaa6

File tree

2 files changed

+26
-20
lines changed

2 files changed

+26
-20
lines changed

src/components/slider/slider.js

Lines changed: 19 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -53,20 +53,22 @@ function SliderDirective($$rAF, $window, $mdAria, $mdUtil, $mdConstant, $mdThemi
5353
scope: {},
5454
require: '?ngModel',
5555
template:
56-
'<div class="md-track-container">' +
57-
'<div class="md-track"></div>' +
58-
'<div class="md-track md-track-fill"></div>' +
59-
'<div class="md-track-ticks"></div>' +
60-
'</div>' +
61-
'<div class="md-thumb-container">' +
62-
'<div class="md-thumb"></div>' +
63-
'<div class="md-focus-thumb"></div>' +
64-
'<div class="md-focus-ring"></div>' +
65-
'<div class="md-sign">' +
66-
'<span class="md-thumb-text"></span>' +
67-
'</div>' +
68-
'<div class="md-disabled-thumb"></div>' +
69-
'</div>',
56+
'<div class="md-slider-wrapper">\
57+
<div class="md-track-container">\
58+
<div class="md-track"></div>\
59+
<div class="md-track md-track-fill"></div>\
60+
<div class="md-track-ticks"></div>\
61+
</div>\
62+
<div class="md-thumb-container">\
63+
<div class="md-thumb"></div>\
64+
<div class="md-focus-thumb"></div>\
65+
<div class="md-focus-ring"></div>\
66+
<div class="md-sign">\
67+
<span class="md-thumb-text"></span>\
68+
</div>\
69+
<div class="md-disabled-thumb"></div>\
70+
</div>\
71+
</div>',
7072
link: postLink
7173
};
7274

@@ -85,7 +87,7 @@ function SliderDirective($$rAF, $window, $mdAria, $mdUtil, $mdConstant, $mdThemi
8587
};
8688

8789
var isDisabledParsed = attr.ngDisabled && $parse(attr.ngDisabled);
88-
var isDisabledGetter = isDisabledParsed ?
90+
var isDisabledGetter = isDisabledParsed ?
8991
function() { return isDisabledParsed(scope.$parent); } :
9092
angular.noop;
9193
var thumb = angular.element(element[0].querySelector('.md-thumb'));
@@ -270,8 +272,8 @@ function SliderDirective($$rAF, $window, $mdAria, $mdUtil, $mdConstant, $mdThemi
270272
function setSliderPercent(percent) {
271273
activeTrack.css('width', (percent * 100) + '%');
272274
thumbContainer.css(
273-
$mdConstant.CSS.TRANSFORM,
274-
'translate3d(' + (percent * 100) + '%,0,0)'
275+
'left',
276+
(percent * 100) + '%'
275277
);
276278
element.toggleClass('md-min', percent === 0);
277279
}

src/components/slider/slider.scss

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,11 @@ md-slider {
5252
display: block;
5353
margin-left: 4px;
5454
margin-right: 4px;
55+
padding: 0;
56+
57+
.md-slider-wrapper {
58+
position: relative;
59+
}
5560

5661
/**
5762
* Track
@@ -84,9 +89,8 @@ md-slider {
8489
.md-thumb-container {
8590
position: absolute;
8691
left: 0;
87-
top: 0;
88-
right: 0;
89-
transform: translate3d(0,0,0);
92+
top: 50%;
93+
transform: translate3d(-50%,-50%,0);
9094
transition: transform 0.1s linear;
9195
}
9296
.md-thumb {

0 commit comments

Comments
 (0)