Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

Commit

Permalink
fix(backdrop): use absolute positioning and anchors
Browse files Browse the repository at this point in the history
css changes work better with sideNav, dialogs, and menus.
fix opaque rendering for dialog backdrops
  • Loading branch information
ThomasBurleson committed Jul 14, 2015
1 parent ee1fed1 commit 87bdf36
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 4 deletions.
9 changes: 7 additions & 2 deletions src/components/backdrop/backdrop.scss
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,9 @@ md-backdrop {

background-color: rgba(0,0,0,0);

position: fixed;
position: absolute;

This comment has been minimized.

Copy link
@mckenzielong

mckenzielong Jul 14, 2015

Contributor

For some reason I recall there being a debate here on github about other elements being fixed vs absolute, but can't find it... Happy to see this changed back 👍

This comment has been minimized.

Copy link
@barryvdh

barryvdh Jul 23, 2015

Contributor

It doesn't work for me. Backdrop doesn't move along with the dialog.

This comment has been minimized.

Copy link
@ThomasBurleson

ThomasBurleson Jul 23, 2015

Author Contributor

@barryvdh - please provide more information and details in a new issue submission.

height: 100%;
bottom:0;
left: 0;
right: 0;

Expand All @@ -32,7 +33,11 @@ md-backdrop {
animation: $swift-ease-out-timing-function mdBackdropFadeIn 0.5s both;
}
&.ng-leave {
animation: $swift-ease-in-timing-function mdBackdropFadeOut 0.2s both;
animation: $swift-ease-in-timing-function mdBackdropFadeOut 0.4s both;
}

&.md-opaque {
background-color: rgba(0,0,0,0.42);
}
}

Expand Down
4 changes: 2 additions & 2 deletions src/components/sidenav/sidenav.scss
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,15 @@ $sidenav-min-space: 56px !default;
md-sidenav {
box-sizing: border-box;
position: absolute;
flex-direction: column;
z-index: $z-index-sidenav;

width: $sidenav-default-width;
min-width: $sidenav-default-width;
max-width: $sidenav-default-width;
bottom: 0;
z-index: $z-index-sidenav;
background-color: white;
overflow: auto;
flex-direction: column;

*,
*:before,
Expand Down

0 comments on commit 87bdf36

Please sign in to comment.