This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(select): interimElement will resolve its promise even when transi…
…tion end event is not fired Occassionally the transitionEnd event will not fire and the '$mdUtil. waitTransitionEnd()' process will timeout; which rejects the pending promise. Using '.finally()' allows the correct handlers to fire and will continuing to propagate the rejected promise. Fixes #3704. Fixes #3780. Fixes #3800. Closes #3794.
- Loading branch information
d6a938e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be some kind of unit test to demonstrate this problem before fixing, right?
d6a938e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are correct. Here: eaa3324#diff-f2959b258f9f15e9926746ff0784840e
d6a938e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice