This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(mdMenu): add md-prevent-menu-close
- Loading branch information
1 parent
818652d
commit e9bcec1
Showing
2 changed files
with
19 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shouldn't this just be one of the following?
<md-button md-prevent-menu-close>
<md-button md-prevent-menu-close="true">
I feel like having it set to the string is confusing. Since the code doesn't actually check the value, I think option 1 would be more clear on it's capabilities.